This repository has been archived by the owner on Oct 24, 2023. It is now read-only.
chore: simplify addons config for calico and flannel #3773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3773 +/- ##
==========================================
- Coverage 73.20% 73.20% -0.01%
==========================================
Files 148 148
Lines 25375 25384 +9
==========================================
+ Hits 18576 18582 +6
- Misses 5663 5666 +3
Partials 1136 1136
Continue to review full report at Codecov.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR removes some of the sed tomfoolery for calico and flannel addons specs and instead uses go templating for more easier maintenance.
Also modified the E2E test cluster configs so that the "calico" test uses kubenet for IPAM, and the "calico_azure" test config uses Azure CNI.
Issue Fixed:
Requirements:
Notes: